Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unusual exclusions stopped working in coverage 4 #455

Closed
nedbat opened this issue Dec 15, 2015 · 3 comments
Closed

Unusual exclusions stopped working in coverage 4 #455

nedbat opened this issue Dec 15, 2015 · 3 comments
Labels
bug Something isn't working

Comments

@nedbat
Copy link
Owner

nedbat commented Dec 15, 2015

In https://github.com/flowroute/ebb-lint, the py27 exclusions don't seem to be working in the 2.7 build. See line 85 in flake8.py
Tested with commit 2d4dc9d09f4a9af78b58ea962f042415d24430ef (bb).
Coverage.py 3.7.1 excludes the lines properly, 4.0.3 does not.


@nedbat
Copy link
Owner Author

nedbat commented Dec 15, 2015

This almost certainly has to do with the fact that the exclusion has a non-ascii character in it, and the match is being made between a utf-8 regex and a unicode source.

@nedbat
Copy link
Owner Author

nedbat commented Dec 24, 2015

Non-ascii characters work again in config regexes. Fixes #455.

→ <<cset a1d9d3e8b813 (bb)>>

@nedbat
Copy link
Owner Author

nedbat commented Dec 24, 2015

Fixed in a1d9d3e8b813 (bb)

@nedbat nedbat closed this as completed Dec 24, 2015
@nedbat nedbat added major bug Something isn't working labels Jun 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant