Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible missed branch to a negative line #466

Closed
nedbat opened this issue Jan 17, 2016 · 3 comments
Closed

Impossible missed branch to a negative line #466

nedbat opened this issue Jan 17, 2016 · 3 comments
Labels
bug Something isn't working

Comments

@nedbat
Copy link
Owner

nedbat commented Jan 17, 2016

Originally reported by Donald Stufft (Bitbucket: dstufft, GitHub: dstufft)


I'm being told that I'm missing a branch from line 404 to line -68. This seems impossible to me since a negative line makes zero sense.

Should be able to reproduce by cloning github.com/pypa/linehaul, checking out commit e6fd40a, installing requirements-dev.txt (I'm running CPython 3.5.1 on OSX if it matters) and then running make tests.


@nedbat
Copy link
Owner Author

nedbat commented Jan 17, 2016

Original comment by Donald Stufft (Bitbucket: dstufft, GitHub: dstufft)


You can see the output here by the way: https://travis-ci.org/pypa/linehaul/jobs/102996327

@nedbat
Copy link
Owner Author

nedbat commented Jan 19, 2016

Fix #466: multi-line statements first in decorated functions

Also, leave in the SetSpy tracer we've used before to find things like this.

→ <<cset 8fe58047bf3c (bb)>>

@nedbat
Copy link
Owner Author

nedbat commented Jan 19, 2016

Fixed in 8fe58047bf3c (bb). Turns out it was due to a multi-line statement as the first thing in a decorated function....

@nedbat nedbat closed this as completed Jan 19, 2016
@nedbat nedbat added major bug Something isn't working labels Jun 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant