Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML report / phystokens.py doesn't handle backslash line changes in DOS files #53

Closed
nedbat opened this issue Mar 13, 2010 · 3 comments
Labels
bug Something isn't working

Comments

@nedbat
Copy link
Owner

nedbat commented Mar 13, 2010

Originally reported by Anonymous


Hello,

It looks like phystokens.py has some hacks to go around backslash line changes. This doesn't seem to work when the source file has DOS line changes (\r\n).

I'll try to attach a small patch to fix this. This might not be the optimal one, but works for me.

Also Python 3.x might do something automatic for all open()s, and 2.x has 'U' flag for open (which is not always available).

Tested on Python 2.6.4 (Linux).


@nedbat
Copy link
Owner Author

nedbat commented Mar 13, 2010

Original comment by Jyrki Muukkonen (Bitbucket: jvtm, GitHub: jvtm)


Here's the patch, looks like I was not logged in. Some problems today with bitbucket.

@nedbat
Copy link
Owner Author

nedbat commented Mar 13, 2010

Fixed in <<changeset 5e8caf64f0ea (bb)>>.

@nedbat nedbat closed this as completed Mar 13, 2010
@nedbat
Copy link
Owner Author

nedbat commented May 19, 2010

Original comment by Geoff Bache (Bitbucket: geoffbache, GitHub: Unknown)


Issue #66 was marked as a duplicate of this issue.

@nedbat nedbat added major bug Something isn't working labels Jun 23, 2018
agronholm added a commit to agronholm/coveragepy that referenced this issue Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant