-
-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[report] omit overwrites [run] omit #622
Comments
Thanks for using coverage.py. Can you provide more detail? If reporting is going to omit a file, then why is it a problem for run to omit it? |
Original comment by Max Nordlund (Bitbucket: maxnordlund, GitHub: maxnordlund) I want to exclude some files completely, not contributing to the global It sounds kind of weird, but it's to reduce noise until coverage goes up Now, it would be sort of OK for run to omit what report is omitting, but it Does this make it clearer? |
Fixed in 1031ead7ca4c (bb) |
Don't confuse run-include with report-include (and also omit). Fixes #621 and #622. → <<cset 1031ead7ca4c (bb)>> |
This was included in coverage.py v4.5, released today. |
Original comment by Max Nordlund (Bitbucket: maxnordlund, GitHub: maxnordlund) Thank you |
Originally reported by Max Nordlund (Bitbucket: maxnordlund, GitHub: maxnordlund)
First let me say thanks for providing such an amazing tool, really makes a huge difference for code health.
I'm using pytest-cov, but it doesn't parse the .coveragerc so I believe it's a coverage bug. Basically if you provide an
omit
option in [run] and [report] the last in the file wins.This is because both store their value in
_omit
, as you can see here. I'm not sure how to fix it though, as I just started to read through the source.The text was updated successfully, but these errors were encountered: