New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicit path alias matching order for coverage combine #649
Labels
Comments
@jbeezley An OrderedDict sounds like a good approach. I've dropped Python 2.6 support since you wrote this up. |
nedbat
added a commit
that referenced
this issue
Nov 18, 2019
nedbat
added a commit
that referenced
this issue
Dec 1, 2019
I've fixed this in 65b9007. Thanks for the detailed example. It's now enshrined in my test suite! |
nedbat
added a commit
that referenced
this issue
Dec 1, 2019
This was released as part of 5.0b2 today. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
nedbat commentedMar 14, 2018
Originally reported by Jonathan Beezley (Bitbucket: jbeezley, GitHub: jbeezley)
Over in https://github.com/girder/girder, we have a fairly convoluted use case where we need to use path aliases for our
coverage combine
step, but we also need ensure that the matching occurs in the correct order. To gloss over some of the messy details, the issue is that in a development install we have the following directory structure:But when installed, the package looks like this:
We need to be able to combine coverage files executed from both of these environments,so we use a path alias that looks like this:
The issue here is that it matches the
girder
section first and aliases the plugin modules to$PWD/girder/plugins
rather than$PWD/plugins
.Globbing patterns don't allow us to exclude only certain subdirectories from the second group, so we need to have some way to ensure that the it is matched after the first.
I would be willing to implement one of the following solutions. I would appreciate any guidance as to which approach (if any) would be preferred by the maintainers.
OrderedDict
on this line so that the original order in the config file is preserved. This would be ideal, but it would require a backport ofOrderedDict
for python 2.6 support.The text was updated successfully, but these errors were encountered: