Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup for ctx in html reports is finicky #855

Closed
rpkilby opened this issue Oct 11, 2019 · 7 comments
Closed

Popup for ctx in html reports is finicky #855

rpkilby opened this issue Oct 11, 2019 · 7 comments
Labels
bug

Comments

@rpkilby
Copy link

@rpkilby rpkilby commented Oct 11, 2019

Describe the bug
For HTML reports, the popup for the new "Who Tests What" ctx element can be a bit finicky. If you attempt to mouse over the popup box (e.g., to copy the list of test names), the popup will close, as you are no longer hovering over the ctx element. If you move the mouse quickly, you may be able to hover over the popup before it disappears, but this is unreliable and annoying.

Video
https://i.imgur.com/Zsgb3AA.mp4
The report was built using coverage v5.0a8

Expected behavior
I should be able to reliably mouse over the ctx popup so I can copy the list of test functions.
One possible solution: clicking the ctx element could pin/unpin its popup. Clicking another ctx would close all other popups.

@rpkilby rpkilby added the bug label Oct 11, 2019
@nedbat

This comment has been minimized.

Copy link
Owner

@nedbat nedbat commented Oct 11, 2019

You are right, it's not good the way it is now. I'll try to improve it.

@rpkilby

This comment has been minimized.

Copy link
Author

@rpkilby rpkilby commented Oct 11, 2019

Thanks, and I'm really looking forward to the 5.0 release. The context feature is great.

nedbat added a commit that referenced this issue Oct 13, 2019
nedbat added a commit that referenced this issue Oct 13, 2019
@nedbat

This comment has been minimized.

Copy link
Owner

@nedbat nedbat commented Oct 13, 2019

I did a big refactor of how the HTML report markup is structured, as of a58a8ab. Give it a try.

@nedbat nedbat closed this Oct 13, 2019
@rpkilby

This comment has been minimized.

Copy link
Author

@rpkilby rpkilby commented Oct 14, 2019

The context expansion works great. Not sure if it's related to the changes, but there's a rendering issue with partially covered lines.

Screen Shot 2019-10-13 at 8 06 34 PM

@nedbat

This comment has been minimized.

Copy link
Owner

@nedbat nedbat commented Oct 14, 2019

Oops, forgot to check the two together. Fixed in 168f1e7. Thanks for the quick feedback! :)

@rpkilby

This comment has been minimized.

Copy link
Author

@rpkilby rpkilby commented Oct 14, 2019

Of course. Thanks again.

@nedbat

This comment has been minimized.

Copy link
Owner

@nedbat nedbat commented Nov 11, 2019

This finished version of this is available in 5.0b1: https://pypi.org/project/coverage/5.0b1/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.