Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
os.path.relpath fails when saving a coverage file with coverage 5 in a folder from a different Windows drive #895
Describe the bug
In the scikit-learn test suite we have a test that launches a subprocess and the atexit registry triggers the saving of a coverage file in a tempfolder in d:\ while the current working directory has been changed by
I do not understand why the traceback starts at
When rolling back to coverage 4.5.3, the problem disappears.
This problems happens with coverage 5.0 and Python 3.7.5 with the latest pytest and pytest-cov.
It seems tricky to reproduce, in particular I do not understand why this only happens in the subprocess tests of scikit-learn and never in the main process itself. Maybe the current working directory is restored to the d:\ tempfolder prior to writing the coverage files?
Anyhow the details can be found in the CI logs of this pull request where I have patched the
I will open a PR to fix the issue in coveragepy.
It looks similar to #824 but the error message is actually different.
awesome -- thanks for the triage and fix on this! this is affecting pytest's testsuite as well (it was quite a bit harder to track down in python3 as the stacktrace doesn't mention coverage at all! fortunately our maintenance branch showed the failures in python2)
for completeness (and perhaps so others can find in google), here are the traces we saw:
I've ran into this with virtualenv CI too - see https://dev.azure.com/pypa/virtualenv/_build/results?buildId=16409&view=logs&jobId=18fdbe60-1f00-5bb0-ebb2-c0f5cf5b2053&j=6ae96b06-827a-58da-753b-f69475679149&t=1bc2b072-5378-5303-372a-95d81e0bbf25; any planned release with a fix?