Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paths cannot be altered by plugins #967

Closed
gaborbernat opened this issue Apr 1, 2020 · 4 comments · Fixed by #969
Closed

paths cannot be altered by plugins #967

gaborbernat opened this issue Apr 1, 2020 · 4 comments · Fixed by #969
Labels
enhancement

Comments

@gaborbernat
Copy link
Contributor

@gaborbernat gaborbernat commented Apr 1, 2020

https://coverage.readthedocs.io/en/latest/config.html#paths shows how to user can set paths. This cannot be achieved by plugins due to paths not being defined as a set/get option; but rather directly as attribute on the configuration object. Due to https://github.com/nedbat/coveragepy/blob/master/coverage/control.py#L272-L276 the plugin cannot reliably access and extend this.

Came up while trying to address asottile/covdefaults#3

@gaborbernat
Copy link
Contributor Author

@gaborbernat gaborbernat commented Apr 11, 2020

Any plans for a release anytime soon?☺️

nedbat added a commit that referenced this issue Apr 11, 2020
@nedbat
Copy link
Owner

@nedbat nedbat commented Apr 11, 2020

Fixed in edadbec.

nedbat added a commit that referenced this issue Apr 11, 2020
@nedbat
Copy link
Owner

@nedbat nedbat commented Apr 12, 2020

This is available in 5.1: https://pypi.org/project/coverage/5.1/

@gaborbernat
Copy link
Contributor Author

@gaborbernat gaborbernat commented Apr 12, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants