Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending to also include all branch attributes #966

merged 1 commit into from Apr 11, 2020


Copy link

The current jsonreport does not include the attributes for covered_branches and missing_branches.

This PR extends such that it includes these attributes; it also updates to account for these newly-dumped attributes.

Current test status:

  py27: commands succeeded
SKIPPED:  py35: InterpreterNotFound: python3.5
  py36: commands succeeded
SKIPPED:  py37: InterpreterNotFound: python3.7
SKIPPED:  py38: InterpreterNotFound: python3.8
SKIPPED:  py39: InterpreterNotFound: python3.9
SKIPPED:  pypy2: InterpreterNotFound: pypy2
SKIPPED:  pypy3: InterpreterNotFound: pypy3

Copy link

aytey commented Apr 6, 2020

@nedbat any thoughts on this? This seems like a great change, as it allows us to get access to data that would otherwise be missing from the json report.

Signed-off-by: Salvatore Zagaria <>
Copy link

Codecov Report

Merging #966 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #966   +/-   ##
  Coverage   94.10%   94.10%           
  Files          86       86           
  Lines       12107    12107           
  Branches     1212     1212           
  Hits        11393    11393           
  Misses        580      580           
  Partials      134      134           
Impacted Files Coverage Δ
coverage/ 100.00% <ø> (ø)
tests/ 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1720459...f5eb5f2. Read the comment docs.

Copy link

nedbat commented Apr 11, 2020

Thanks, I'll add the fields to the individual files also.

@nedbat nedbat merged commit b1194fb into nedbat:master Apr 11, 2020
Copy link

nedbat commented Apr 12, 2020

This is available in 5.1:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants