Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Make it AMD compatible. #73

Closed
klimashkin opened this Issue · 16 comments

15 participants

klimashkin Patrik Patie Gmitter cusial jonira Efremov Alexey Cosmin Stefan-Dobrin Kashif Shamaz Jhon Cruz Francesco Uliana Jenna Pederson davidcalhoun Paul T. Hermann Yung Nedim Arabacı Bram Wubs
klimashkin

Hello!
Would like to use it with RequireJS as define module.
Possible solution is here: https://github.com/umdjs/umd/blob/master/jqueryPlugin.js

Patrik Patie Gmitter

:+1: +1 for requirejs

cusial

+1 for require.js

jonira

+1 now using this is just pure pain

Efremov Alexey

+1 for require.js

Cosmin Stefan-Dobrin

+1 for AMD (RequireJS)

Kashif Shamaz

+1 for AMD version.

Jhon Cruz

+1 for requirejs

Francesco Uliana

+1 for requirejs

Patrik Patie Gmitter

one year and no response.. @needim ?

Jenna Pederson

+1 for require.js

davidcalhoun

Is this ever going to be implemented? Surprised to see it available on npm without being CommonJS or UMD compatible.

Paul T.

+1 for AMD support

Hermann Yung

+1 for AMD

Nedim Arabacı needim referenced this issue from a commit
Nedim Arabacı amd compability #73 2e0a79e
Nedim Arabacı
Owner

Can you test v2.2.10. And sorry for the delay.

Paul T.

@needim I'm looking at the packaged files under the archive for 2.2.10 and they do not include the code wrapper that your last commit added to the Gruntfile.
Also, I'm looking at your changes and there are still some "leading" code in the setup... I'll post some comments on your commit.

Nedim Arabacı needim closed this
Bram Wubs

How would I get this script to work with requirejs? I had to manually add return noty at the end of js/noty/packaged/jquery.noty.packaged.js in order to make it work when doing something like

define(['tools/noty'], function (noty) {
 .. 
});

When I remove the return statement I get Uncaught TypeError: undefined is not a function when trying to execute noty({...});

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.