Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Make it AMD compatible. #73

Closed
klimashkin opened this Issue Aug 16, 2012 · 16 comments

Comments

Hello!
Would like to use it with RequireJS as define module.
Possible solution is here: https://github.com/umdjs/umd/blob/master/jqueryPlugin.js

patie commented Oct 29, 2012

👍 +1 for requirejs

cusial commented Nov 21, 2012

+1 for require.js

jonira commented Jun 27, 2013

+1 now using this is just pure pain

lexich commented Jul 29, 2013

+1 for require.js

+1 for AMD (RequireJS)

+1 for AMD version.

+1 for requirejs

+1 for requirejs

patie commented Dec 18, 2013

one year and no response.. @needim ?

+1 for require.js

Is this ever going to be implemented? Surprised to see it available on npm without being CommonJS or UMD compatible.

purtuga commented Oct 18, 2014

+1 for AMD support

mkyung commented Oct 19, 2014

+1 for AMD

@needim needim added a commit that referenced this issue Oct 23, 2014

@needim needim amd compability #73 2e0a79e
Owner

needim commented Oct 23, 2014

Can you test v2.2.10. And sorry for the delay.

purtuga commented Oct 24, 2014

@needim I'm looking at the packaged files under the archive for 2.2.10 and they do not include the code wrapper that your last commit added to the Gruntfile.
Also, I'm looking at your changes and there are still some "leading" code in the setup... I'll post some comments on your commit.

@needim needim closed this Dec 21, 2014

megawubs commented Jan 9, 2015

How would I get this script to work with requirejs? I had to manually add return noty at the end of js/noty/packaged/jquery.noty.packaged.js in order to make it work when doing something like

define(['tools/noty'], function (noty) {
 .. 
});

When I remove the return statement I get Uncaught TypeError: undefined is not a function when trying to execute noty({...});

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment