Skip to content

Loading…

IE incompatibility issue resolved #57

Closed
wants to merge 2 commits into from

6 participants

@theand

these two things makes error in IE. (I've tested in IE 8/Win7)

  1. change name of 'default' theme to 'defaults'
    js/noty/jquery.noty.js
    js/noty/themes/default.js
    demo/*.html

  2. remove misplaced comma in an object
    js/noty/themes/default.js

@theand theand change name of 'default' theme to 'defaults', remove misplaced comma …
…in an object

1. change name of 'default' theme to 'defaults'
js/noty/jquery.noty.js
js/noty/themes/default.js
demo/*.html

2. remove  misplaced comma in an object
js/noty/themes/default.js

these two things makes error in IE 8.
ec5f77d
@needim
Owner

Hi @theand Thanks for PR! Can you change PR target to develop branch please?

@fredericseiler

With @theand files, i had to remove one more misplaced comma in themes\default.js (line 69 - backgroundColor: '#fff',), but now it works on IE8. Thanks for the patch !

@needim, thanks for this great plugin.

@breadmj

Oh,, super thanks @theand !! and thanks to @needim for this super cool plugin.

@theand theand another misplaced comma
@leonidsakharov  pointed out another misplaced comma
958ecab
@theand theand closed this
@yeskarthik

On IE 7 and 8 am getting an error :
Line 88 of jquery.noty.js self.options.theme.style.apply(self); -- options.theme.style is null or not an object
Can you please fix it?

@msdevweb

This .default property also breaks on iOS 4.3 (iPhone/iPad) default browser (iOS 5 correct this).

Renaming the defaults to something else worked like a charm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jul 26, 2012
  1. @theand

    change name of 'default' theme to 'defaults', remove misplaced comma …

    theand committed
    …in an object
    
    1. change name of 'default' theme to 'defaults'
    js/noty/jquery.noty.js
    js/noty/themes/default.js
    demo/*.html
    
    2. remove  misplaced comma in an object
    js/noty/themes/default.js
    
    these two things makes error in IE 8.
Commits on Jul 27, 2012
  1. @theand

    another misplaced comma

    theand committed
    @leonidsakharov  pointed out another misplaced comma
Something went wrong with that request. Please try again.