New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show welcome screen unless library is empty. #340

Merged
merged 3 commits into from Oct 13, 2018

Conversation

Projects
None yet
2 participants
@psetq
Contributor

psetq commented Aug 27, 2018

This should fix issue #330 where existing podcasts were not shown after visiting the "top 100" screen.

Basically, it let's the MainWindow decide whether to show the welcome screen depending on if the Library is empty or not.

The second commit is a minor unrelated change, but I noticed that when creating the database tables on first run the method was opening the database to a local db variable which shadowed the object var of the same name. The result was a method that seems to open the database, but where db could actually still be null after this method returns.

psetq added some commits Aug 27, 2018

Don't show welcome screen unless library is empty.
When returning from the "Top 100" view, only show the welcome screen if the library is empty.
Use existing `prepare_database` method to open sqlite database when c…
…reating tables.

The `setup_library` method was opening a database connection to a local `db` variable which
shadowed the object member variable. This change simply uses the existing `prepare_database`
to open and hold the database connection more consistently.
Show welcome screen if last remaining podcast deleted.
If the last podcast is deleted leaving an empty library we should see
the welcome screen instead of an empty one after deletion.
@nathandyer

This comment has been minimized.

Show comment
Hide comment
@nathandyer

nathandyer Oct 11, 2018

Member

Thanks for the PR! The code looks good to me, and the changes make sense. I just want to pull it and test it on a real system before I merge it in.

Member

nathandyer commented Oct 11, 2018

Thanks for the PR! The code looks good to me, and the changes make sense. I just want to pull it and test it on a real system before I merge it in.

@nathandyer nathandyer merged commit a2a85c9 into needle-and-thread:master Oct 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment