From 3bcb350711135cab5a16e6f1a917d7caa59ceedf Mon Sep 17 00:00:00 2001 From: Bjorn Neergaard Date: Fri, 3 Feb 2023 05:05:50 -0700 Subject: [PATCH] graphdriver/overlay2: usingMetacopy ENOTSUP is non-fatal Signed-off-by: Bjorn Neergaard --- daemon/graphdriver/overlay2/check.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/daemon/graphdriver/overlay2/check.go b/daemon/graphdriver/overlay2/check.go index d16ee3555cd26..b8738700a87da 100644 --- a/daemon/graphdriver/overlay2/check.go +++ b/daemon/graphdriver/overlay2/check.go @@ -188,6 +188,11 @@ func usingMetacopy(d string) (bool, error) { // ...and check if the pulled-up copy is marked as metadata-only xattr, err := system.Lgetxattr(filepath.Join(l2, "f"), overlayutils.GetOverlayXattr("metacopy")) if err != nil { + // ENOTSUP signifies the FS does not support either xattrs or metacopy. In either case, + // it is not a fatal error, and we should report metacopy as unused. + if errors.Is(err, unix.ENOTSUP) { + return false, nil + } return false, errors.Wrap(err, "metacopy flag was not set on file in the upperdir") } usingMetacopy := xattr != nil