Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing implementation about `unique` #73

Closed
item4 opened this issue Jan 13, 2016 · 5 comments
Closed

missing implementation about `unique` #73

item4 opened this issue Jan 13, 2016 · 5 comments

Comments

@item4
Copy link
Contributor

@item4 item4 commented Jan 13, 2016

See 932 line. What is Sizzle's API?

There is no impl, only misplaced text :(

@item4

This comment has been minimized.

Copy link
Contributor Author

@item4 item4 commented Jan 13, 2016

I think we can use Set of innerHTML of each element.

@camsong

This comment has been minimized.

Copy link
Member

@camsong camsong commented Jan 13, 2016

where is the line 932?

@item4

This comment has been minimized.

Copy link
Contributor Author

@item4 item4 commented Jan 13, 2016

@camsong

This comment has been minimized.

Copy link
Member

@camsong camsong commented Jan 13, 2016

@camsong

This comment has been minimized.

Copy link
Member

@camsong camsong commented Jan 15, 2016

We found that there are rare occasions that need to use unique when play with Virtual DOM, and this method rely on DOM manipulation heavily, so I will remove it for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.