Remove OutputClass for Intel card as it's automatically detected #10

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@jdieter

jdieter commented Dec 23, 2016

The OutputClass lines are unneeded for Intel cards as X will automatically choose the modesetting driver instead of the intel driver (even when the intel driver is specified) when using a laptop with dual graphics cards.

The problem with leaving the Intel OutputClass lines in is that they force the use of the modesetting driver, even if on a system without an Nvidia card (or, in my case, a multiseat system where the Intel and Nvidia cards drive two separate seats and run on separate X servers), which causes these systems to fall back to software rendering.

This has been tested on my laptop with dual Nvidia/Intel graphics running F25, negativo17.org multimedia, and libglvnd-enabled mesa, and everything works as expected.

This has also been tested on a school multiseat system with Nvidia, AMD and Intel graphics cards. The Nvidia card correctly uses the binary driver, while the other three Intel and AMD cards use the libglvnd-enabled mesa drivers.

Remove OutputClass for Intel card as it's automatically detected when
needed and can cause problems when it's not needed

Signed-off-by: Jonathan Dieter <jdieter@lesbg.com>
@scaronni

This comment has been minimized.

Show comment
Hide comment
@scaronni

scaronni Dec 23, 2016

Member

Hi, thanks for looking at this, especially considering that the change is unreleased. Actually the idea of putting the Intel section comes from discussion with Hans De Geode:

http://hansdegoede.livejournal.com/16668.html

The basic idea is that by installing the Nvidia driver on an Optimus laptop, hybrid graphics would be set up automatically. As far as I remembered the use of modesetting is not automatic (yet) but I might be wrong.

I'm currently on holiday with limited access, will revert back to this topic in a few days.

Thanks & regards,
--Simone

Member

scaronni commented Dec 23, 2016

Hi, thanks for looking at this, especially considering that the change is unreleased. Actually the idea of putting the Intel section comes from discussion with Hans De Geode:

http://hansdegoede.livejournal.com/16668.html

The basic idea is that by installing the Nvidia driver on an Optimus laptop, hybrid graphics would be set up automatically. As far as I remembered the use of modesetting is not automatic (yet) but I might be wrong.

I'm currently on holiday with limited access, will revert back to this topic in a few days.

Thanks & regards,
--Simone

@jdieter

This comment has been minimized.

Show comment
Hide comment
@jdieter

jdieter Jan 8, 2017

I hope you had a great holiday. Sorry for the delay in getting back to you. I've been following Hans' blog as well, and he's doing great stuff.

As I said, I have an Optimus laptop that I'm running with the supplied patch, and the modesetting stuff is automatic (at least with xorg-x11-server-1.19.0-3.fc25, which was just pushed into stable yesterday).

jdieter commented Jan 8, 2017

I hope you had a great holiday. Sorry for the delay in getting back to you. I've been following Hans' blog as well, and he's doing great stuff.

As I said, I have an Optimus laptop that I'm running with the supplied patch, and the modesetting stuff is automatic (at least with xorg-x11-server-1.19.0-3.fc25, which was just pushed into stable yesterday).

@scaronni

This comment has been minimized.

Show comment
Hide comment
@scaronni

scaronni Jan 9, 2017

Member

Thanks, I've notified Hans. I just need a confirmation from him for this and I can push the updated packages.

Member

scaronni commented Jan 9, 2017

Thanks, I've notified Hans. I just need a confirmation from him for this and I can push the updated packages.

@jwrdegoede

This comment has been minimized.

Show comment
Hide comment
@jwrdegoede

jwrdegoede Jan 9, 2017

Contributor

Hi,

The selecting of the modesetting driver over the intel driver is only done on skylake systems (this is a Fedora specific patch) and then it is done on all systems, not just optimus systems.

We do plan to follow Debian in using the modesetting by default on all but the oldest Intel chipsets for F26, in the mean time the Intel config snippet you suggest to be removed is necessary because using the intel driver on optimus laptops completely breaks things and as said the Fedora pkgs only prefer modesetting over the intel driver for skylake and newer for now.

I can see how this causes an undesirable behavior change for your specific setup. But the modesetting driver is not unaccelerated, it simply uses slightly different acceleration paths. As said it will become the default for Intel gfx on F26+ anyways, so please give it a try and if you're seeing any issues with it file a bug in RH bugzilla and put me in the Cc,

Regards,

Hans

Contributor

jwrdegoede commented Jan 9, 2017

Hi,

The selecting of the modesetting driver over the intel driver is only done on skylake systems (this is a Fedora specific patch) and then it is done on all systems, not just optimus systems.

We do plan to follow Debian in using the modesetting by default on all but the oldest Intel chipsets for F26, in the mean time the Intel config snippet you suggest to be removed is necessary because using the intel driver on optimus laptops completely breaks things and as said the Fedora pkgs only prefer modesetting over the intel driver for skylake and newer for now.

I can see how this causes an undesirable behavior change for your specific setup. But the modesetting driver is not unaccelerated, it simply uses slightly different acceleration paths. As said it will become the default for Intel gfx on F26+ anyways, so please give it a try and if you're seeing any issues with it file a bug in RH bugzilla and put me in the Cc,

Regards,

Hans

@jdieter

This comment has been minimized.

Show comment
Hide comment
@jdieter

jdieter Jan 9, 2017

Hans, thanks. My Optimus laptop is skylake, so that explains why it's working out of the box without the config snippet. The multiseat systems I'm using are not skylake, so I'll go ahead and start filing bugs when I run into issues.

Simone, sorry for the noise.

jdieter commented Jan 9, 2017

Hans, thanks. My Optimus laptop is skylake, so that explains why it's working out of the box without the config snippet. The multiseat systems I'm using are not skylake, so I'll go ahead and start filing bugs when I run into issues.

Simone, sorry for the noise.

@jdieter jdieter closed this Jan 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment