Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flatpak-extension subpackage #57

Closed
wants to merge 2 commits into from

Conversation

TingPing
Copy link

@TingPing TingPing commented Aug 26, 2018

This is useful for Flatpak users always having the exact same driver version as the host.

@@ -35,6 +35,14 @@
%global _glvnd_libdir %{_libdir}/libglvnd
%endif

%ifarch i686

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just use %{ix86} here.

This is useful for Flatpak users always having the exact same
driver version as the host.
@scaronni
Copy link
Member

scaronni commented Sep 22, 2018

Sorry for the late reply, been pretty busy. I'm not sure I understand what this package is for.
Also, the base libs subpackage provides these:

libEGL_nvidia.so.0()(64bit)
libGLESv1_CM_nvidia.so.1()(64bit)
libGLESv2_nvidia.so.2()(64bit)
libGLX_nvidia.so.0()(64bit)
libnvidia-cfg.so.1()(64bit)
libnvidia-eglcore.so.396.54()(64bit)
libnvidia-glcore.so.396.54()(64bit)
libnvidia-glsi.so.396.54()(64bit)
libnvidia-glvkspirv.so.396.54()(64bit)
libnvidia-tls.so.396.54()(64bit)
libvdpau_nvidia.so.1()(64bit)
nvidia-driver-libs = 3:396.54-2.fc28
nvidia-driver-libs(x86-64) = 3:396.54-2.fc28
libEGL_nvidia.so.0
libGLESv1_CM_nvidia.so.1
libGLESv2_nvidia.so.2
libGLX_nvidia.so.0
libnvidia-eglcore.so.396.54
libnvidia-glcore.so.396.54
libnvidia-glsi.so.396.54
libnvidia-glvkspirv.so.396.54
libnvidia-tls.so.396.54
libvdpau_nvidia.so.1
nvidia-driver-libs = 3:396.54-2.fc28
nvidia-driver-libs(x86-32) = 3:396.54-2.fc28

Thaf flatpak subpackage provides the same, and being flatpak-extension alphabetically earlier than libs it gets pulled in the place of the normal libs.

Why not installing the libs subpackage directly?

@TingPing
Copy link
Author

TingPing commented Sep 22, 2018

I'm not sure I understand what this package is for.

For more details see this: https://blog.tingping.se/2018/08/26/flatpak-host-extensions.html

Why not installing the libs subpackage directly?

They have to be in Flatpak's directory to be used by it.

Thaf flatpak subpackage provides the same, and being flatpak-extension alphabetically earlier than libs it gets pulled in the place of the normal libs.

Hmm, I imagine there is a way to disable those automatic provides since these libs aren't used by other packages.

@Conan-Kudo
Copy link

%global __provides_exclude_from ^%{_flatpakdir}/.*$

@mati865
Copy link

mati865 commented Oct 4, 2018

There is merge conflict because of aa1c481

@scaronni
Copy link
Member

scaronni commented Oct 5, 2018

To be honest I don't know what to do with this PR as I'm not a flatpak user and I don't understand the implications.

Copy link

@leigh123linux leigh123linux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use symlinks instead, using cp is wasteful.

@Conan-Kudo
Copy link

@leigh123linux Symlinks wouldn't resolve in the bubblewrapped environment.

@matthiasclasen
Copy link

To be honest I don't know what to do with this PR as I'm not a flatpak user and I don't understand the implications.

The implications are that we will have a working nvidia driver for flatpak apps out-of-the-box on Fedora, without maintaining a Flatpak extension that has to match your driver exactly, somewhere else, and dealing with the unavoidable version skews and delays due to that.

We are certainly willing to help maintain and test this subpackage from the flatpak side.

@scaronni
Copy link
Member

scaronni commented Nov 30, 2018

Ok. @matthiasclasen can you please rebase including the comments from @Conan-Kudo (if any)?

Ideally I would like to have the same SPEC file buildable on all supported EPEL / Fedora releases, so please take into consideration that. Thanks.

@scaronni
Copy link
Member

Is this still relevant?

@TingPing
Copy link
Author

Nothing has changed.

@scaronni
Copy link
Member

scaronni commented Jun 6, 2019

Anyone doing a rebase? Otherwise I will close the issue.

@scaronni
Copy link
Member

scaronni commented Sep 9, 2019

No one has proposed any rebase, closing this. Feel free to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants