-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flatpak-extension subpackage #57
Conversation
11d97d7
to
2c55cb9
Compare
nvidia-driver.spec
Outdated
@@ -35,6 +35,14 @@ | |||
%global _glvnd_libdir %{_libdir}/libglvnd | |||
%endif | |||
|
|||
%ifarch i686 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just use %{ix86}
here.
This is useful for Flatpak users always having the exact same driver version as the host.
2c55cb9
to
890beb2
Compare
Sorry for the late reply, been pretty busy. I'm not sure I understand what this package is for.
Thaf flatpak subpackage provides the same, and being Why not installing the |
For more details see this: https://blog.tingping.se/2018/08/26/flatpak-host-extensions.html
They have to be in Flatpak's directory to be used by it.
Hmm, I imagine there is a way to disable those automatic provides since these libs aren't used by other packages. |
|
a15a091
to
3fd2b41
Compare
There is merge conflict because of aa1c481 |
To be honest I don't know what to do with this PR as I'm not a flatpak user and I don't understand the implications. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use symlinks instead, using cp is wasteful.
@leigh123linux Symlinks wouldn't resolve in the bubblewrapped environment. |
The implications are that we will have a working nvidia driver for flatpak apps out-of-the-box on Fedora, without maintaining a Flatpak extension that has to match your driver exactly, somewhere else, and dealing with the unavoidable version skews and delays due to that. We are certainly willing to help maintain and test this subpackage from the flatpak side. |
Ok. @matthiasclasen can you please rebase including the comments from @Conan-Kudo (if any)? Ideally I would like to have the same SPEC file buildable on all supported EPEL / Fedora releases, so please take into consideration that. Thanks. |
Is this still relevant? |
Nothing has changed. |
Anyone doing a rebase? Otherwise I will close the issue. |
No one has proposed any rebase, closing this. Feel free to reopen. |
This is useful for Flatpak users always having the exact same driver version as the host.