New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shlomif pull req challenge changes #4

Merged
merged 4 commits into from Mar 1, 2015

Conversation

Projects
None yet
2 participants
@shlomif

shlomif commented Mar 1, 2015

This pull request:

  1. Adds MIN_PERL_VERSION for Kwalitee.
  2. Adds .gitignore.
  3. Removes some trailing whitespace.

I also noticed that the README is too long and contains a lot of fluff information. Is there any interest in preparing a shorter and briefer README? Currently it is auto-generated from one of the PODs, but maybe it should be written manually.

neilb added a commit that referenced this pull request Mar 1, 2015

@neilb neilb merged commit 99a2618 into neilb:master Mar 1, 2015

@neilb

This comment has been minimized.

Owner

neilb commented Mar 1, 2015

Thanks. A shorter README sounds good. My current model for a good README is something like the README for Business::CCCheck:

  • title that identifies the file and dist
  • first paragraph from the DESCRIPTION - a paragraph saying what it is
  • where you can see the doc
  • where you go can to find out how to install it
  • author, possibly license/copyright
@neilb

This comment has been minimized.

Owner

neilb commented Mar 1, 2015

Version 1.70 on its way to CPAN. I fixed a couple of small things off the RT list as well.

Thanks again.

shlomif added a commit to shlomif/AppConfig that referenced this pull request Mar 1, 2015

@shlomif

This comment has been minimized.

shlomif commented Mar 1, 2015

@neilbowers : you're welcome and thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment