ManifestDir is Deprecated in Puppet4 #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure about it... I can't package puppet4 without using collection ? |
|
Ok i changed it to set the MANIFESTDIR environment directory instead of --manifestdir so i'm hoping this will work in all cases. @grubernaut @ytsarev what do you think? |
|
can you please write small test to cover these configuration combinations ? |
|
i've done testing and will merge in 2 day's time if no objections |
|
LGTM |
Merged
ytsarev
pushed a commit
that referenced
this pull request
Nov 9, 2015
…Puppet4 ManifestDir is Deprecated in Puppet4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if require_puppet_collections is specified don't specify the manifest_dir. My understanding is you can only install puppet v4 via collections so this should work. please review and merge if you agree with this change. @grubernaut @ytsarev