Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add method "add_video" to SummaryWriter #2

Merged
merged 3 commits into from May 12, 2018
Merged

Conversation

raahii
Copy link
Contributor

@raahii raahii commented May 7, 2018

I implemented the feature of logging a video clip as gif images to tensorboard. I used this pull request as reference.

@codecov-io
Copy link

codecov-io commented May 7, 2018

Codecov Report

Merging #2 into master will decrease coverage by 0.02%.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #2      +/-   ##
==========================================
- Coverage   87.07%   87.04%   -0.03%     
==========================================
  Files          25       25              
  Lines        1052     1096      +44     
==========================================
+ Hits          916      954      +38     
- Misses        136      142       +6
Impacted Files Coverage Δ
setup.py 0% <ø> (ø) ⬆️
tb_chainer/writer.py 89.74% <100%> (+0.17%) ⬆️
examples/demo.py 100% <100%> (ø) ⬆️
tb_chainer/summary.py 91.17% <85%> (-2.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a2feeb...0d6e282. Read the comment docs.

@neka-nat
Copy link
Owner

neka-nat commented May 9, 2018

Thank you, raahii!
I think that it is a very good function.
But the coverage has declined, so can you add test?

@neka-nat
Copy link
Owner

Thanks!

@neka-nat neka-nat merged commit 339dcfe into neka-nat:master May 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants