New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sql_obj() incorrent @bind #1

Merged
merged 3 commits into from Feb 19, 2015

Conversation

Projects
None yet
2 participants
@spechenin
Contributor

spechenin commented Feb 7, 2015

Bug:
$sql = sql_obj('SELECT * FROM table WHERE ') + sql_obj('col = ?', 1)
$sql->bind() results in [undef, 1]

spechenin added some commits Feb 7, 2015

add test to catch a bug in sql_obj
sql_obj without binding parameter introduce undef value in binding list.
$sql = sql_obj("SELECT * FROM table")
$sql->bind() results in [undef], must be []
fix a bug in sql_obj()
sql_obj() without binding parameter introduce undef value in binding list.
$sql = sql_obj("SELECT * FROM table")
$sql->bind() results in [undef], must be []

@spechenin spechenin closed this Feb 14, 2015

@spechenin spechenin deleted the spechenin:prc branch Feb 14, 2015

@spechenin spechenin restored the spechenin:prc branch Feb 14, 2015

@spechenin spechenin reopened this Feb 14, 2015

@spechenin spechenin changed the title from Fix a bug in sql_obj to Fix sql_obj() incorrent @bind Feb 14, 2015

@spechenin spechenin changed the title from Fix sql_obj() incorrent @bind to fix sql_obj() incorrent @bind Feb 14, 2015

nekokak added a commit that referenced this pull request Feb 19, 2015

@nekokak nekokak merged commit f90dd6c into nekokak:master Feb 19, 2015

@spechenin spechenin deleted the spechenin:prc branch Feb 26, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment