New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/data2row #116

Merged
merged 6 commits into from Feb 14, 2014

Conversation

Projects
None yet
6 participants
@karupanerura
Copy link
Contributor

karupanerura commented Aug 30, 2013

No description provided.

@tokuhirom

This comment has been minimized.

Copy link
Collaborator

tokuhirom commented Aug 30, 2013

+1

@cho45

This comment has been minimized.

Copy link
Collaborator

cho45 commented Sep 9, 2013

benri

@cho45

This comment has been minimized.

Copy link
Collaborator

cho45 commented Sep 24, 2013

But I think there is better name for this function. (eg. Teng->row_from_hash(name, hash), Teng->temporary(name, data), Teng->unsaved(name, hash) ... any idea?)

@tokuhirom

This comment has been minimized.

Copy link
Collaborator

tokuhirom commented Sep 24, 2013

I suggest Teng->new_row($table, $row) or Teng->new_row_from_hash($table, $hash)..

@GeJ

This comment has been minimized.

Copy link
Contributor

GeJ commented Oct 1, 2013

May I suggest Teng->inflate_to($table, $data) or maybe inflate_data or simply inflate?

@Songmu

This comment has been minimized.

Copy link
Contributor

Songmu commented Feb 13, 2014

new_row_from_hash sounds good.

@karupanerura

This comment has been minimized.

Copy link
Contributor

karupanerura commented Feb 14, 2014

Sorry for the late reply. new_row_from_hash looks like good. I will replace to it.

dayflower and others added some commits Oct 18, 2013

Trim get_inflator / get_deflator from POD.
get_inflator() and get_deflator() are not implemented.
Change add_(?:inf|def)lator from set_(?:inf|def)lator in POD.
Teng::Schema::Table#set_inflator() (and that for deflator) are not implemented.
Instead, add_inflator() and add_deflator() are defined.
@karupanerura

This comment has been minimized.

Copy link
Contributor

karupanerura commented Feb 14, 2014

cho45 added a commit that referenced this pull request Feb 14, 2014

@cho45 cho45 merged commit a55db53 into nekokak:master Feb 14, 2014

@cho45

This comment has been minimized.

Copy link
Collaborator

cho45 commented Feb 14, 2014

Merged

@karupanerura

This comment has been minimized.

Copy link
Contributor

karupanerura commented Feb 14, 2014

Thank you!

@karupanerura karupanerura deleted the karupanerura:feature/data2row branch Feb 14, 2014

@cho45

This comment has been minimized.

Copy link
Collaborator

cho45 commented Feb 14, 2014

Released as 0.21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment