Node overlap rendering is not correct

[Nelarius]

When dragging nodes over each other, the rendering is glitchy due to all node frames being rendered in a loop in EndNodeEditor. It would be better to render the frame after EndNode is called so that the node frame and ImGui UI are at least rendered in the same order.

[ketoo]

Meet the same issue.

[NukeBird]

are there any improvements?

[Nelarius]

Not yet 😞 I think I am going start working on this issue next week, going to try to fix a few other fundamental issues as well.

[ketoo]

Great, please let me know if you need any help that comes from other developers.

[NukeBird]

Cool! Keep it up, I really love your lib!
It's pretty simple in comparison with others

[Nelarius]

Thanks, happy to hear that you think so! 😊

[Nelarius]

All right, finally made some progress on this. Now nodes are nicely rendered on top of each other if they overlap. It's not perfect though: clicking and dragging a node doesn't put it in top of other nodes automatically -- the "depth order" depends on which order you called BeginNode/EndNode. It would be nice to have more control over the depth order of the node draw commands, but that's another issue. I will close this issue 🙂

@ketoo I had to delete IsAttributeLinked and therefore remove the pin linked/unlinked rendering 😞 Really sorry for breaking the feature so soon after you wrote it! To fix the overlap issue, I had to movedraw_node and draw_pin from EndNodeEditor to EndNode(), which meant that the link connectivity information is no longer available at that point. So the pins are back to being simple filled shapes for now. One of the drawbacks of being an immediate mode UI is that you have to throw the state away at the end of every frame 😬

[ketoo]

All right, finally made some progress on this. Now nodes are nicely rendered on top of each other if they overlap. It's not perfect though: clicking and dragging a node doesn't put it in top of other nodes automatically -- the "depth order" depends on which order you called BeginNode/EndNode. It would be nice to have more control over the depth order of the node draw commands, but that's another issue. I will close this issue 🙂

@ketoo I had to delete IsAttributeLinked and therefore remove the pin linked/unlinked rendering 😞 Really sorry for breaking the feature so soon after you wrote it! To fix the overlap issue, I had to movedraw_node and draw_pin from EndNodeEditor to EndNode(), which meant that the link connectivity information is no longer available at that point. So the pins are back to being simple filled shapes for now. One of the drawbacks of being an immediate mode UI is that you have to throw the state away at the end of every frame 😬

No worry, the application can manage the pin's status by itself. To do this, the pin system needs to support more shapes, for instance, the solid triangle and the hollow triangle, which can meet the same goal. Actually, my application has all statuses about the nodes and pins, which means the application can pass the status when drawing the nodes and pins.

[Nelarius]

Yeah, my application also has the connectivity information. So what we now need is to be able to set per-pin style, and allow the pin shape style to be hollow or filled 👍

[ketoo]

Great, thats enough for the developer.

[Nelarius]

I added filled/unfilled shapes to master.

[ketoo]

Cool! I updated and it works. But I meet a new issue when I run the application on MAC, listed as below:

This issue will come when I resize the window.

[Nelarius]

Looks like something fails deep inside OpenGL 😯 Are you sure it was imnode's triggering this crash? imnodes itself doesn't touch window resize logic, nor did the pin rendering changes have anything to do with UI event handling 🤔

[ketoo]

I have done a test, the result shows that the issue comes from Imgui itself.