Change the resources definition assumption#256
Closed
KuiKui wants to merge 1 commit intonelmio:masterfrom
Closed
Conversation
|
👍 |
Author
|
I don't care of tests now. I just want to discuss 😺 |
Member
|
I'd rather not do this because it's bound to fail or conflict depending on your URL layout and the depth of the resources you have. It'll generate support/issues burden and showing the common url prefix is kind of ok IMO. A better alternative possibly could be to allow resource="" instead of just resource=true, so you can define the resource name yourself? |
Author
|
I'm ok with you for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
After