New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the resources definition assumption #256

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@KuiKui

KuiKui commented Oct 9, 2013

  • strip the last param (cause it's not representative of a resource)
  • get the resource name (assuming that is the last one in the url)

Before

Before

After

After

@fdubost

This comment has been minimized.

Show comment
Hide comment
@fdubost

fdubost Oct 9, 2013

Contributor

👍

Contributor

fdubost commented Oct 9, 2013

👍

@KuiKui

This comment has been minimized.

Show comment
Hide comment
@KuiKui

KuiKui Oct 9, 2013

I don't care of tests now. I just want to discuss 😺

KuiKui commented Oct 9, 2013

I don't care of tests now. I just want to discuss 😺

@Seldaek

This comment has been minimized.

Show comment
Hide comment
@Seldaek

Seldaek Oct 9, 2013

Member

I'd rather not do this because it's bound to fail or conflict depending on your URL layout and the depth of the resources you have. It'll generate support/issues burden and showing the common url prefix is kind of ok IMO.

A better alternative possibly could be to allow resource="" instead of just resource=true, so you can define the resource name yourself?

Member

Seldaek commented Oct 9, 2013

I'd rather not do this because it's bound to fail or conflict depending on your URL layout and the depth of the resources you have. It'll generate support/issues burden and showing the common url prefix is kind of ok IMO.

A better alternative possibly could be to allow resource="" instead of just resource=true, so you can define the resource name yourself?

@Seldaek Seldaek closed this Oct 9, 2013

@KuiKui

This comment has been minimized.

Show comment
Hide comment
@KuiKui

KuiKui Oct 10, 2013

I'm ok with you for the resource="".
The PR is coming soon 👷

KuiKui commented Oct 10, 2013

I'm ok with you for the resource="".
The PR is coming soon 👷

@fdubost fdubost referenced this pull request Oct 11, 2013

Merged

Allow to named resources #258

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment