Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the resources definition assumption #256

Conversation

@KuiKui
Copy link

@KuiKui KuiKui commented Oct 9, 2013

  • strip the last param (cause it's not representative of a resource)
  • get the resource name (assuming that is the last one in the url)

Before

Before

After

After

@fdubost
Copy link
Contributor

@fdubost fdubost commented Oct 9, 2013

👍

@KuiKui
Copy link
Author

@KuiKui KuiKui commented Oct 9, 2013

I don't care of tests now. I just want to discuss 😺

@Seldaek
Copy link
Member

@Seldaek Seldaek commented Oct 9, 2013

I'd rather not do this because it's bound to fail or conflict depending on your URL layout and the depth of the resources you have. It'll generate support/issues burden and showing the common url prefix is kind of ok IMO.

A better alternative possibly could be to allow resource="" instead of just resource=true, so you can define the resource name yourself?

@Seldaek Seldaek closed this Oct 9, 2013
@KuiKui
Copy link
Author

@KuiKui KuiKui commented Oct 10, 2013

I'm ok with you for the resource="".
The PR is coming soon 👷

@fdubost fdubost mentioned this pull request Oct 11, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants