Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Symfony 5 #136

Merged
merged 4 commits into from Nov 6, 2019

Conversation

@GawainLynch
Copy link
Contributor

GawainLynch commented Oct 24, 2019

This is probably going to need a few changes based on feedback. I just thought I'd get it all together & testable first.

There are two related upstream PRs for SymfonyTest SymfonyTest/SymfonyDependencyInjectionTest#121 and SymfonyTest/SymfonyConfigTest#63 to make the DI test package work.

That is where part of the version bump(s) come in. The package has a BC break in signatures after v3, and v4 requires PHPUnit 8 for TestCase compatibility.

So please let me know what more is wanted, or not, and I'll happily work to get this over the line 馃樅

Summary

  • Drop PHP < 7.1 7.2
  • Drop Symfony < 4.3 4.0
  • Deprecations for HttpKernel Events
  • Drop matthiasnoback/symfony-dependency-injection-test
  • Update Travis to use PHPUnit 8.3
  • Remove syntaxCheck from phpunit.xml
  • Signature updates
- Drop PHP < 7.2
- Drop Symfony < 4.0
- Deprecations for HttpKernel Events
- matthiasnoback/symfony-dependency-injection-test:^4.0
- Update to use PHPUnit 8.3
  - Remove syntaxCheck from phpunit.xml
  - Signature updates
@fabpot

This comment has been minimized.

Copy link

fabpot commented Nov 1, 2019

As this bundle is used by API Platform... ans because I want to write a chapter on API Platform in my upcoming Symfony book... that should be finished really soon now, I would appreciate a version of this bundle that supports Symfony 5 :)

composer.json Outdated Show resolved Hide resolved
.travis.yml Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
@GawainLynch

This comment has been minimized.

Copy link
Contributor Author

GawainLynch commented Nov 5, 2019

@nicolas-grekas I've pushed a change that drops the test library & bumps PHP requirements on Travis down to 7.1 馃帀

@Seldaek

This comment has been minimized.

Copy link
Member

Seldaek commented Nov 5, 2019

Seems fine to me, all good to merge then or did you wanna do more @GawainLynch ?

@GawainLynch

This comment has been minimized.

Copy link
Contributor Author

GawainLynch commented Nov 6, 2019

I'd say :shipit:, thank you @Seldaek 馃憤

@Seldaek Seldaek merged commit 10059a2 into nelmio:master Nov 6, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Seldaek

This comment has been minimized.

Copy link
Member

Seldaek commented Nov 6, 2019

Thank you for the work

@GawainLynch GawainLynch deleted the GawainLynch:symfony-5 branch Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can鈥檛 perform that action at this time.