Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to force Access-Control-Allow-Origin value #67

Merged
merged 2 commits into from Dec 30, 2016
Merged

Add an option to force Access-Control-Allow-Origin value #67

merged 2 commits into from Dec 30, 2016

Conversation

Oliboy50
Copy link
Contributor

@Oliboy50 Oliboy50 commented Aug 31, 2016

Why

See #66

First commit

Feature + preflight requests tested

Second commit

"Normal" response tested + refactoring of CorsListener::options attribute

=> because $this->options was always empty while executing CorsListener::onKernelResponse()... I don't think it's the case in production environment (I hope so), but at least in test environment: I just couldn't find a way to make it work the way it was done before :(

@Oliboy50
Copy link
Contributor Author

@Oliboy50 Oliboy50 commented Oct 20, 2016

any news for this?

@Seldaek
Copy link
Member

@Seldaek Seldaek commented Oct 21, 2016

No sorry been really busy lately haven't had time to review this in depth yet.

@Seldaek Seldaek merged commit 0f73575 into nelmio:master Dec 30, 2016
1 check passed
@Seldaek
Copy link
Member

@Seldaek Seldaek commented Dec 30, 2016

Thanks

@Oliboy50 Oliboy50 deleted the feat/forced_allow_origin_value branch Dec 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants