Add an option to force Access-Control-Allow-Origin value #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
any news for this? |
|
No sorry been really busy lately haven't had time to review this in depth yet. |
|
Thanks |
This was referenced Dec 30, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Why
See #66
First commit
Feature + preflight requests tested
Second commit
"Normal" response tested + refactoring of
CorsListener::optionsattribute=> because
$this->optionswas always empty while executingCorsListener::onKernelResponse()... I don't think it's the case in production environment (I hope so), but at least in test environment: I just couldn't find a way to make it work the way it was done before :(