/NelmioCorsBundle

Add an option to force Access-Control-Allow-Origin value #67

Merged
merged 2 commits into from Dec 30, 2016
+123 −12

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Oliboy50 @Seldaek
@Oliboy50
Contributor

Oliboy50 commented Aug 31, 2016

Why

See #66

First commit

Feature + preflight requests tested

Second commit

"Normal" response tested + refactoring of CorsListener::options attribute

=> because $this->options was always empty while executing CorsListener::onKernelResponse()... I don't think it's the case in production environment (I hope so), but at least in test environment: I just couldn't find a way to make it work the way it was done before :(

@Oliboy50 Oliboy50 referenced this pull request Aug 31, 2016

Closed

Be able to force Access-Control-Allow-Origin header value #66

@Oliboy50

This comment has been minimized.

Show comment
Hide comment
@Oliboy50

Oliboy50 Oct 20, 2016

Contributor

any news for this?
Contributor

Oliboy50 commented Oct 20, 2016

any news for this?
@Seldaek

This comment has been minimized.

Show comment
Hide comment
@Seldaek

Seldaek Oct 21, 2016

Member

No sorry been really busy lately haven't had time to review this in depth yet.
Member

Seldaek commented Oct 21, 2016

No sorry been really busy lately haven't had time to review this in depth yet.

@Seldaek Seldaek merged commit 0f73575 into nelmio:master Dec 30, 2016
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Seldaek

This comment has been minimized.

Show comment
Hide comment
@Seldaek

Seldaek Dec 30, 2016

Member

Thanks
Member

Seldaek commented Dec 30, 2016

Thanks

This was referenced Dec 30, 2016

Closed
Closed

@Oliboy50 Oliboy50 deleted the Oliboy50:feat/forced_allow_origin_value branch Dec 30, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment