Add Symfony 5 to the long list of supported versions

[damienalexandre]

This PR supersede #209 as the logic is different, here we keep support for all versions by using class_exists a lot.

Thanks to @lyrixx I discovered that the setUp() : void from PHPUnit issue is normally managed by the PHPUnit Bridge! 😍

[damienalexandre]

Tests are ok on PHP 7.1+, still need to figure out why SYMFONY_PHPUNIT_REMOVE_RETURN_TYPEHINT=1 does not work as expected.

[Seldaek]

Thanks for the work, let me know once you figure out the build failure and I happily merge..

[damienalexandre]

Would it be okay to drop PHP 5.4?

I cannot make it work with it:

• the phpunit bridge > 4.2 is PHP 5.5 only
• the methods replacing "expectedException" annotations are not poly-filled in phpunit bridge <= 4.2

This is the last and only blocker for this PR.

[damienalexandre]

Tests are now green but PHP 5.4 has been removed. It does not mean the bundle does not work anymore, it's just we can't run the tests on this version.

[damienalexandre]

Thanks for the review, I just switched all the return to a clear Exception message, added a test, added the final annotation and bumped PHP minimal version in composer.

[damienalexandre]

Twig is now bumped to 1.38, which is the minimal version we can use with support for the namespaced classes.

I also changed all Twig related code to use the namespaced classes to avoid some errors and make it "clean".

PHP Fatal error: Declaration of Nelmio\SecurityBundle\Twig\TokenParser\AbstractCSPParser::parse(Twig_Token $token) must be compatible with Twig\TokenParser\TokenParserInterface::parse(Twig\Token $token) in /**/NelmioSecurityBundle/Twig/TokenParser/AbstractCSPParser.php on line 57

[damienalexandre]

Hi there, is there anything I can do to help going forward with this PR? It's good to go from my point of view 👍

Thank you!

[romainneutron]

I propose to merge this and release in version 3.0

[damienalexandre]

It's perfectly okay to release a minor version, there is not BC break here.

[romainneutron]

@damienalexandre Could you rebase this one?

[damienalexandre]

Rebased 👍

If a squash is needed as well, let me know 😉