Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

navigator/project_tree: force a switch _before_ doing redraw/relayout #173

Merged
merged 2 commits into from Sep 19, 2019

Conversation

@nelsam
Copy link
Owner

commented Sep 19, 2019

When the project was changed via the UI, the open navigator pane would change after all of the redraw/relayout logic
happened. This caused the project tree to be unresponsive and often display the incorrect project.

Type

  • Bug Fix
  • New Feature
  • Quality of Life Improvement

Tests

I have tested locally against:

  • Windows
  • linux
  • OS X
  • BSD

I have included automated tests:

  • Unit tests
  • Integration tests
  • End to end tests

The navigator package is probably the oldest, crustiest part of vidar right now, and it needs a major rewrite to be testable. I don't even want to try to test it right now.

nelsam added 2 commits Sep 19, 2019
When the project was changed via the UI, the open navigator pane would change _after_ all of the redraw/relayout logic
happened.  This caused the project tree to be unresponsive and often display the incorrect project.
Resolves #169
@ionrock

This comment has been minimized.

Copy link

commented Sep 19, 2019

This fixes #174 for me.

@nelsam nelsam merged commit d631dfc into master Sep 19, 2019
2 checks passed
2 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nelsam nelsam deleted the projects-ui-freeze branch Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.