Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gocode: fix off-by-one error (<= instead of <) #184

Merged
merged 1 commit into from Oct 19, 2019

Conversation

@nelsam
Copy link
Owner

nelsam commented Oct 19, 2019

When deciding whether or not we can apply a suggestion, we used < when we should have
been using <=. This meant that suggestions could only be completed when at least one
character had already been typed of the resulting word.

Type

  • Bug Fix
  • New Feature
  • Quality of Life Improvement

Tests

I have tested locally against:

  • Windows
  • linux
  • OS X
  • BSD

I have included automated tests:

  • Unit tests
  • Integration tests
  • End to end tests
When deciding whether or not we can apply a suggestion, we used < when we should have
been using <=.  This meant that suggestions could only be completed when at least one
character had already been typed of the resulting word.
@nelsam nelsam merged commit a2e69ff into master Oct 19, 2019
3 checks passed
3 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.