Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Out-of-source build doesn't work out of box #10

Closed
eustas opened this issue Dec 8, 2016 · 3 comments
Closed

Out-of-source build doesn't work out of box #10

eustas opened this issue Dec 8, 2016 · 3 comments

Comments

@eustas
Copy link

eustas commented Dec 8, 2016

[at least for brotli] current directory is not used as a destination of generated build files.
Scenario like this won't work as expected:
mkdir out && cd out && ../configure
A hack is required to fix behaviour:
mkdir out && cd out && ../configure --pass-thru -B.

@nemequ
Copy link
Owner

nemequ commented Dec 8, 2016

Can you be more specific? That's how I always build stuff with this script and it always works. I also just tried dropping a copy of this script in my brotli tree, and it works as expected.

@eustas
Copy link
Author

eustas commented Dec 8, 2016

Oh, the things break only if someone occasionally runs ./configure in root project folder.
After this CMake sticks to root folder, unless -B. is specified (because of CMakeCache.txt file).

@nemequ
Copy link
Owner

nemequ commented Dec 8, 2016

Ah, that makes sense.

I don't see the -B flag documented anywhere, where are you getting that? It's not in cmake(1)… If that's something we could add to the cmake command without causing problems I'd be willing to do so, but this seems like more of a CMake problem, and they don't seem interested in fixing it.

@eustas eustas closed this as completed Dec 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants