Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trezor - remaining transaction types #531

Merged

Conversation

@darrenlangley
Copy link
Contributor

darrenlangley commented Oct 29, 2019

Added TransactionConfirmation modal to remaining transaction types so that they can support Trezor signing.

Copy link
Collaborator

decentraliser left a comment

please check the review

darrenlangley and others added 4 commits Oct 30, 2019
…-desktop-wallet into trezor-transaction-types
…-desktop-wallet into trezor-transaction-types
@decentraliser

This comment has been minimized.

Copy link
Collaborator

decentraliser commented Oct 31, 2019

please ping me when the PR is ready!

@decentraliser

This comment has been minimized.

Copy link
Collaborator

decentraliser commented Oct 31, 2019

The Alias transactions are broken, please have a look. If you need help, do not hesitate to ask me

@decentraliser

This comment has been minimized.

Copy link
Collaborator

decentraliser commented Nov 1, 2019

MultisigTransactionFormTs is missing from this PR, I'll do it in another one

@decentraliser decentraliser merged commit f93ca9f into nemfoundation:develop Nov 6, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.