Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added MnemonicQR, ExportMnemonicDataSchema and encoders #12

Merged
merged 10 commits into from Sep 11, 2019
Merged

Added MnemonicQR, ExportMnemonicDataSchema and encoders #12

merged 10 commits into from Sep 11, 2019

Conversation

evias
Copy link
Contributor

@evias evias commented Sep 6, 2019 •
edited

Added

  • Added MnemonicQR and ExportMnemonicDataSchema to create QR codes containing password encrypted mnemonic pass phrase.
  • Added encoders/ to deal with different encoding practices, currently only supports ASCII, Canvas and Base64.
  • Added examples/ with WIP on browser/client-side integration.

Fixed

  • Fixed AccountQR size to version 15, added MnemonicQR to encrypt mnemonic pass phrases.
  • Fixed ASCII encoding and refactored to encoders/.
  • Renamed chainId to generationHash for consistency with protocol.
  • Upgraded dependencies including qrcode and typescript.

AnthonyLaw
AnthonyLaw approved these changes Sep 11, 2019
View reviewed changes
Copy link
Member

@AnthonyLaw AnthonyLaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

related #10

@evias evias merged commit 5161108 into master Sep 11, 2019
@evias evias deleted the add-encoders branch September 11, 2019 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnthonyLaw AnthonyLaw AnthonyLaw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@evias @AnthonyLaw