Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[boot] mcompositor service files with new boot targets #4

Merged
merged 8 commits into from Jul 5, 2013
Merged

[boot] mcompositor service files with new boot targets #4

merged 8 commits into from Jul 5, 2013

Conversation

xavinux
Copy link
Contributor

@xavinux xavinux commented Jul 4, 2013

No description provided.

@plundstr
Copy link
Contributor

plundstr commented Jul 4, 2013

Seems that mcompositor has .yaml files.
You should have done most of the changes to .yaml before spec
Also notice that the service you are starting and stopping in post and postun sections is using wrong name (you copy pasted without editing

@plundstr
Copy link
Contributor

plundstr commented Jul 5, 2013

You have not run specify after changing .yaml
Some changes you made to .spec will be lost after next run.
You should first run specify and then edit .spec file only between >> << marks.

@plundstr
Copy link
Contributor

plundstr commented Jul 5, 2013

wrong service started/stopped in post/postun

@plundstr
Copy link
Contributor

plundstr commented Jul 5, 2013

LGTM

plundstr pushed a commit that referenced this pull request Jul 5, 2013
Merge pull request #4 from xavinux/master
40ae9dc 
[boot] mcompositor service files with new boot targets
@plundstr plundstr merged commit 40ae9dc into nemomobile-graveyard:master Jul 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xavinux @plundstr