Add email plugin #15
Merged
Add email plugin #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,6 +1,6 @@ | |||
| TEMPLATE = lib | |||
| CONFIG += qt plugin hide_symbols | |||
| QT += declarative | |||
| QT += declarative webkit network | |||
There was a problem hiding this comment.
please do this inside email/src/src.pro, not everything requires webkit/network
|
please update README in the root to note the existence of this plugin. I haven't reviewed the C++ as I'm assuming it's basically just a direct copy - so there's not much point |
|
Yes, no changes in c++ part apart from replacing main.cpp with plugin.cpp |
| { | ||
| Q_ASSERT(uri == QLatin1String("org.nemomobile.email")); | ||
|
|
||
| qmlRegisterType<FolderListModel>(uri, 0, 1, "FolderListModel"); |
There was a problem hiding this comment.
cough, shouldn't have made me look :-)
your indentation is off here
There was a problem hiding this comment.
Crap, copy past fail :P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check that it works for you :)