Bugfix for loading the same image/thumbnail twice caused loading error. #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You were right! Now it works and the fix is much better. |
| @@ -262,12 +262,13 @@ void NemoThumbnailItem::updateThumbnail(bool identityChanged) | |||
| } | |||
|
|
|||
| void NemoThumbnailLoader::updateRequest(NemoThumbnailItem *item, bool identityChanged) | |||
| { | |||
| { | |||
There was a problem hiding this comment.
You should teach your editor to strip trailing whitespace..
special
added a commit
that referenced
this pull request
Feb 14, 2013
Bugfix for loading the same image/thumbnail twice caused loading error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is really a right way to fix this, but at least it fixed the problem. The problem was that if I was trying to load the same thumbnail twice, loading the second time failed.