Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[n950] N950 plugin with disabled cbs. #265

Closed
wants to merge 1 commit into from

Conversation

locusf
Copy link
Contributor

@locusf locusf commented Nov 27, 2014

As per discussion in #nemomobile, its better if n950 driver was separate from n900, since its cbs cleanup crashes ofono on n9 testing.

@sledges
Copy link

sledges commented Nov 27, 2014

LGTM, we have followed a historic trail path ;) http://comments.gmane.org/gmane.comp.handhelds.ofono/11882
Downside: code duplication
Advantage: codes can continue to diverge should more differences in modems arise, keeping code clean from #ifdefs or ifs() - is not a good thing either, but we avoid breaking n900 since we cannot go back there and test due to scarse HW and nemo on n900 resurrecting only in the future, so we took this compromise

@jpoutiai
Copy link

Good catch but I must ask the same question as Denis Kenzior (https://lists.ofono.org/pipermail/ofono/2012-May/013074.html). Should we rather just remove cbs support as originally suggested considering that N900 is fairly old already and do those still using it need cbs?

@sledges
Copy link

sledges commented Nov 30, 2014

Cell Broadcast Service is not a vital feature (as opposed to my thinking earlier), my apologies, so we could re-open #264 .

Please close this PR, and hope that if any new modem SW modifications arrive in future, they are the same for all devices (which reassures us that N900 and N9/950 modem chips are 1:1 identical) and we won't have to re-open this ;)

@locusf
Copy link
Contributor Author

locusf commented Nov 30, 2014

Okay.

@locusf locusf closed this Nov 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants