Re-enable CBS in n900 plugin and fix CBS related crash in N9 #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on n9 ofono init." This reverts commit 804bef9.
Don't remove cbs data during shutdown sequence in isimodem driver, since it is already being removed. [n900] Fix cbs related crash
|
Looks LGTM. Has this actually been tested in device? Unfortunately I don't have one to test this. |
|
I'll take a look at this today, but in the evening though. |
|
Yes, I've tested it on N9 using Nemo, and it doesn't crash anymore. |
|
Ok can confirm that ofono no longer crashes |
jpoutiai
pushed a commit
that referenced
this pull request
Dec 9, 2014
Re-enable CBS in n900 plugin and fix CBS related crash in N9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-enables CBS in n900 plugin and fixes resulted crash in isimodem driver. The crash was caused by trying to remove cbs data twice when shutdown sequence was in progress; which happens on N9 because of a modem reset.
Finally, there is an error in changelog which prevents local builds. This PR fixes that problem too.