Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[statusbar] Wifi panel added for statusbar #18

Merged
merged 1 commit into from Jun 19, 2014

Conversation

@locusf
Copy link
Member

commented Jun 19, 2014

No description provided.

@@ -72,9 +72,14 @@ Item {
wlan.path = networkManager.technologyPathForType("wifi")
}
}
function toggle_wifi() {

This comment has been minimized.

Copy link
@SfietKonstantin

SfietKonstantin Jun 19, 2014

Why an empty function here ?

This comment has been minimized.

Copy link
@locusf

locusf Jun 19, 2014

Author Member

Will remove

@@ -140,6 +162,51 @@ Item {
return "image://theme/icon_wifi_0"
}
}
panel: Component {

This comment has been minimized.

Copy link
@SfietKonstantin

SfietKonstantin Jun 19, 2014

Weired indent + very long compoent. Can't you move it to it's own file ?

This comment has been minimized.

Copy link
@locusf

locusf Jun 19, 2014

Author Member

Ok, I'll try that.

import QtQuick.Controls.Nemo 1.0
import QtQuick.Controls.Styles.Nemo 1.0

Component {

This comment has been minimized.

Copy link
@SfietKonstantin

SfietKonstantin Jun 19, 2014

Nipticking: please do correct indentation

@SfietKonstantin

This comment has been minimized.

Copy link

commented Jun 19, 2014

Maybe there is a need of polishing afterwards (less magic numbers and more constants ? etc.) but LGTM now

@locusf

This comment has been minimized.

Copy link
Member Author

commented Jun 19, 2014

Ok will merge.

locusf added a commit that referenced this pull request Jun 19, 2014
[statusbar] Wifi panel added for statusbar
@locusf locusf merged commit dadf526 into nemomobile-ux:master Jun 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.