Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[statusbar] Wifi panel added for statusbar #18

Merged
merged 1 commit into from Jun 19, 2014

Conversation

locusf
Copy link
Member

@locusf locusf commented Jun 19, 2014

No description provided.

@@ -72,9 +72,14 @@ Item {
wlan.path = networkManager.technologyPathForType("wifi")
}
}
function toggle_wifi() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why an empty function here ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will remove

@SfietKonstantin
Copy link

Maybe there is a need of polishing afterwards (less magic numbers and more constants ? etc.) but LGTM now

@locusf
Copy link
Member Author

locusf commented Jun 19, 2014

Ok will merge.

locusf added a commit that referenced this pull request Jun 19, 2014
[statusbar] Wifi panel added for statusbar
@locusf locusf merged commit dadf526 into nemomobile-ux:master Jun 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants