Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[covers] Remove application covers from window model and do not show cov... #5

Merged
merged 1 commit into from Apr 5, 2014

Conversation

locusf
Copy link
Member

@locusf locusf commented Apr 5, 2014

...er as window.

@SfietKonstantin
Copy link

  • Maybe rename org.locusf to org.nemomobile ?
  • Remove debug traces ?
  • Singleton classes might not have a public default constructor. Either remove default constructor, or remove singleton (I prefer removing singleton).
  • Is WindowModel QObject based ? If yes, the constructor should have QObject *parent. And there should be the Q_OBJECT macro.
  • Make your constructors explicit

#include <QQmlContext>
#include "glacierwindowmodel.h"

class QQmlEngine;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need of FW declaration here. You included the headers just before.

@SfietKonstantin
Copy link

LGTM

locusf added a commit that referenced this pull request Apr 5, 2014
[covers] Remove application covers from window model and do not show cov...
@locusf locusf merged commit baaedcc into nemomobile-ux:master Apr 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants