Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[packaging] remove lipstick.desktop #87

Merged
merged 1 commit into from Nov 1, 2018

Conversation

akaWolf
Copy link
Contributor

@akaWolf akaWolf commented Oct 28, 2018

this fixes packaging problem, when packager complains that file is installed but not packaged.

looks like now there is no need to autostart by using xdg, we already use systemd service.

@neochapay
Copy link
Member

You not remove descktop file from spec

@neochapay
Copy link
Member

@neochapay neochapay closed this Oct 29, 2018
@akaWolf
Copy link
Contributor Author

akaWolf commented Oct 29, 2018

You not remove descktop file from spec

yeah, because you did that: c683026

does we still need that mechanism?
as I noted before,

looks like now there is no need to autostart by using xdg, we already use systemd service.

@akaWolf
Copy link
Contributor Author

akaWolf commented Oct 29, 2018

anyway after c683026 we got non-working package:
you delete .desktop entry from %files section, but that file still getting installed:

desktop.files = rpm/lipstick.desktop

rpm guide explicitly highlight that case: https://docs.fedoraproject.org/ro/Fedora_Draft_Documentation/0.1/html/RPM_Guide/ch09s05s07.html

in latest MerSDK, which bundled with SailfishSDK 2.2.1.18, we have:
$ rpmbuild --version RPM version 4.14.1

what leading in packaging error:
Checking for unpackaged file(s): /usr/lib/rpm/check-files /home/deploy/installroot error: Installed (but unpackaged) file(s) found: /etc/xdg/autostart/glacier.desktop

OBS have no error is only because rpmbuild version there is less than 4.1

@akaWolf
Copy link
Contributor Author

akaWolf commented Oct 29, 2018

On obs build fine https://build.merproject.org/package/show/home:neochapay:nemo-ux/lipstick-glacier-home-qt5

in your rpm there is no .desktop file, since you delete those line from spec

@neochapay
Copy link
Member

neochapay commented Oct 30, 2018

  1. Add tag to MR and Commit
  2. Create ISSUE
  3. Don't talk what you do - write why you do that

@neochapay neochapay reopened this Oct 30, 2018
@akaWolf akaWolf changed the title remove lipstick.desktop [packaging] remove lipstick.desktop Oct 30, 2018
@neochapay
Copy link
Member

Try build on OBS ?

@akaWolf
Copy link
Contributor Author

akaWolf commented Oct 31, 2018

@neochapay
Copy link
Member

LGTM

@neochapay neochapay merged commit 758e80f into nemomobile-ux:devel Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants