Fix crashes and clean up the UI #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neochapay
reviewed
Feb 10, 2018
qml/components/PlaylistItem.qml
Outdated
| @@ -9,8 +9,10 @@ ListViewItemWithActions{ | |||
| width: parent.width | |||
| height: Theme.itemHeightHuge | |||
|
|
|||
| icon: cover | |||
| label: artist+" - "+title | |||
| icon: "image://theme/music" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my device the app was crashing when indexing because it wasn't closing the files as it went through.
For UX I added a list view Icon, added some more track information, and removed the next arrow to save more room for text.
The tracks listview will now add songs to the playlist although its not clear when you press the button that anything has happened