New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update keyboard make in configurable and allow change keyboard layout #3
Conversation
add finnish keyboard layout
Fix accented characters in Finnish keyboard layout
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM. Nice @neochapay @juiceme !:)
| key: Qt.Key_Return | ||
| icon: "icon-enter.svg" | ||
| repeat: true | ||
| key: Qt.Key_Backspace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be Qt.Key_Return?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
| rightPadding: keyArea.rightPadding | ||
| bottomPadding: keyArea.bottomPadding | ||
| landscape: true | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the enterkey visible when on landscape?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Landscape keyboard not tested yeat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can be tested by changing, for example TextInputPage, allowedOrientations to
allowedOrientations: Qt.LandscapeOrientation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea....plz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Landscape broken, Portrait looks good.
Where to test changing language? Should glacier-settings be dependency or? (tested on SFOS, didn't have glacier-settings installed)
|
|
||
| property int topPadding: Theme.itemSpacingExtraSmall | ||
| property int bottomPadding: topPadding | ||
| property int leftPadding: Theme.itemSpacingExtraSmall/2 | ||
| property int rightPadding: leftPadding | ||
| property int keyHeight: keyArea.height / 4 | ||
|
|
||
| property int totalCharButtons: Math.max(row1.length, row2.length, row3.length) | ||
|
|
||
| property int keyHeight: keyArea.height / 4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| property variant accents_row1: ["", "", "eèéêë", "", "tþ", "yý", "uûùúü", "iîïìí", "oöôòó", ""] | ||
| property variant accents_row2: ["aäàâáãå", "", "dð", "", "", "", "", "", ""] | ||
| property variant accents_row3: ["", "", "cç", "", "", "nñ", ""] | ||
| property variant row1: KLayouts.keyboards[currentKeyboardLayout]["row1"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
KLayouts is not defined
Missing import "layouts.js" as KLayouts
https://github.com/nemomobile-ux/plugins/pull/3/files#diff-7a0f9e5afcaa997e56f722d487e15352R37
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix
| rightPadding: keyArea.rightPadding | ||
| bottomPadding: keyArea.bottomPadding | ||
| landscape: true | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8ec5b03
to
714a037
Compare
|
All is fixed |

No description provided.