The iphb module uses rtc alarms to wakeup from suspend #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rtc alarm is set to closest maximum time of client wakeup requests. This allows us to wake up from suspend to serve aligned timers. The next (clock/calendar/etc) alarm time is tracked (via listening to "next_bootup_event" signals from timed) and considered when setting the rtc alarm time. When dsme wakes up due to rtc alarm, it takes a wakelock, wakes up clients with elapsed timers and signals cpu-keepalive wakeup to mce via asynchronous D-Bus method call. The wakelock will be released by mce once it has handled the method call. Since dsme now has /dev/rtc open all the time, it effectively blocks other processes from updating the rtc time. To overcome this, iphb module synchronizes rtc time to system time when a) dsme starts up b) while processing heatbeat wakeups c) when "settings_changed" signal is received from timed. Also fixes issues on module startup failure and unload paths.
Since systemd captures stderr too, this just leads to duplicate entries in journal.
Warning message will be emitted if message content differs from what caller expected. Removed message_iter_next() since it left the iterator pointing to the last element instead of moving past it - i.e. you could read the last element N times without errors. Also fixed a type mismatch found due to type checking.
spiiroin
added a commit
that referenced
this pull request
Mar 8, 2013
The iphb module uses rtc alarms to wakeup from suspend
plundstr
pushed a commit
that referenced
this pull request
Oct 8, 2013
Merge pull request #24 from plundstr/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: dsme.spec needs:
BuildRequires: pkgconfig(mce) >= 1.12.3