Fix library dependency checking for Intel targets #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #Get full dependencies of the direct dependencies | ||
| for lib in $DIRECT_LIBS; do | ||
| TEMPDEPS=$($LD_LINUX $lib \ | ||
| | sed -ne "s/.*[\t ]\(\/.*\) (.*/\1/gp") |
There was a problem hiding this comment.
A bit more readable to use sed -ne "s|.*[\t ]\(/.*\) (.*|\1|gp", one backslash less :)
There was a problem hiding this comment.
For me most sed and awk lines are completely incomprehensible no matter how you write it :P
Was the replacement of "/" with pipe "|" intentional?
…s to JB#25193 The sb2 targets for i486/i586 perform really funny library path translations when the binaries are run inside sb2. Hence the old way to detect library dependencies by running them with LD_TRACE_LOADED_OBJECTS=1 flag does not work anymore correctly. Fixed by getting direct dependencies of the executables via objdump and then using ldd to collect dependencies of the direct dependencies. This way the executable does not need to be run to find the dependencies. Signed-off-by: Kalle Jokiniemi <kalle.jokiniemi@jolla.com>
kjokinie
pushed a commit
that referenced
this pull request
Mar 20, 2015
Fix library dependency checking for Intel targets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V2: Added comment about grepping the libraries after objdump
The sb2 targets for i486/i586 perform really funny library path
translations when the binaries are run inside sb2. Hence the old
way to detect library dependencies by running them with
LD_TRACE_LOADED_OBJECTS=1 flag does not work anymore correctly.
Fixed by getting direct dependencies of the executables via objdump
and then using ldd to collect dependencies of the direct dependencies.
This way the executable does not need to be run to find the dependencies.
Signed-off-by: Kalle Jokiniemi kalle.jokiniemi@jolla.com