Code/build cleanup #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good to me |
|
Please do not merge this, as it changes the symbols in the library, making it source and binary incompatible with existing code that may use those interfaces. |
|
This is indeed an API breakage. Though I couldn't find any code using the generated interfaces except the library itself. |
|
I am sure it is better to get rid of them now than later when someone really starts using it. Also it must be clear to everyone those classes are not meant to be considered as part of public API, despite the distinction has not been done explicitly (e.g. use of *_p.h file suffix or Q_DECL_EXPORT etc.) |
Pre-step to introduce use of DBUS_INTERFACES qmake variable. With dash in name, it would generate invalid include guards.
This commit eliminates the need to store (in git) the generated D-Bus interface files and makes make-clean work for them. The problem with including commondbustypes.h is solved by including not only the generated .h file but also generated .cpp file as well as its moc_* file inside the associated API class' source file after commondbustypes.h is included. Note that the .h file still needs to be explicitly included - without being referenced, qmake would not detect any dependency to it and it would not get generated. See networkmanager.cpp: #include "commondbustypes.h" #include "connman_manager_interface.h" #include "connman_manager_interface.cpp" // not bug #include "moc_connman_manager_interface.cpp" // not bug
MOC warned about these.
|
After thinking about it and discussing it, I am ok with the breakage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.