Start refactoring of NetworkingModel: add class TechnologyModel #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The D-Bus path property is used as a string identificator of NetworkService instance in QML.
The class TechnologyModel is supposed to be an initial refactoring of NetworkingModel. The goals are 1. represent the list of services as QAbstractListModel; 2. don't bind the list model to a hardcoded technology (wifi);
|
One important thing is that ConnMan doesn't support multiple Agents at the moment. In fact, if you check on theirs TODO file[1], you will see that they don't expect to support Agents for each technology. Since ConnMan supports ofono, bluez, and others technologies, our Agent should support them. At least should be scalable. |
|
Agree. I think Agent should become a QtQuick component in its own right and not coupled with technologies. |
rojkov
added a commit
that referenced
this pull request
Dec 4, 2012
Start refactoring of NetworkingModel: add class TechnologyModel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to deprecate NetworkingModel, but to keep backward compatibility with existing code for awhile thus the new code goes to TechnologyModel.
TBD: