Add overlay windows handling #25
Conversation
This also fixed maliit issue: the top part of maliit window is now transparent (as it should be) instead of black.
|
Tested as ok on N9. |
| // reparent the overlay to the found layer | ||
| overlayLayer.parent = focusedLayer ? focusedLayer : overlayLayer.parent | ||
| } | ||
| } |
There was a problem hiding this comment.
Hmm, is the reparenting actually necessary, since the overlayLayer has a higher Z than any of the focus item layers?
There was a problem hiding this comment.
Honestly, I trusted you on this :)
Yes, doesn't make much sense to me, but iirc it didn't work correctly without it
|
Otherwise LGTM. Hopefully alpha for wayland items gets fixed at some point so the shader becomes unnecessary. |
|
About reparenting without setting Z: I did some tests, reparenting without setting overlayLayer's higher Z doesn't work, in fact in that case if you open app A and show keyboard and then open app B, the keyboard will show in app A but not in app B, as the reparenting code just sets the parent once in that case (as the focusedLayer will still be appLayer) but app B will be drawn on top of the keyboard as its window has been created after keyboard's one, afaiu. About setting Z without reparenting: I think fixing that issue could be part of this same PR, so I'll wait for your opinion on this before merging, I only spent very short time on this as I've been busy |
|
Merging as per LGTM. |
No description provided.