[orientation] Enable rotation handling #30
Conversation
| QScreen* sc = app.primaryScreen(); | ||
| if(sc){ | ||
| sc->setOrientationUpdateMask(Qt::PrimaryOrientation | ||
| | Qt::LandscapeOrientation |
There was a problem hiding this comment.
Space before { and indent ^_^
There was a problem hiding this comment.
doh! can't belive i missed the space again!
Ignore creator user file Fix style issues Fix NotificationPreview Rotation
| } | ||
|
|
||
| MouseArea { | ||
| id: notificationArea | ||
| property bool isPortrait: (orientationAngleContextProperty.value == 90 || orientationAngleContextProperty.value == 270) | ||
| property bool isPortrait: (orientationAngle == 90 || orientationAngle == 270) |
There was a problem hiding this comment.
isn't this only true on devices where landscape is the default fb orientation?
There was a problem hiding this comment.
We need to think of a mechanism to handle any device regardless of its default orientation.
I vote for let's pull the trigger this time and have nice lipstick rotations on N9, because this change is not what @bzeller introduced (see the deleted line).
When we jump aboard another device with differing default orientation, will solve then
|
This is exactly how it works for me when i tested it on the phone. Messages are on the right place and right direction. In the original code messages where upside down in portrait mode. |
|
LGTM, works ok on N9 |
|
so, we agreed to let this in, we'll eventually look at it when we'll work on the new Glacier homescreen in case we decide to reuse the code :) |
|
We won't look into notifications, because they will be scrapped. |
[orientation] Enable rotation handling
Ignore creator user file