Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various changes to make the homescreen look nicer #9

Merged
merged 12 commits into from Feb 21, 2013
Merged

Various changes to make the homescreen look nicer #9

merged 12 commits into from Feb 21, 2013

Conversation

thp
Copy link
Contributor

@thp thp commented Feb 21, 2013

Not sure if all these changes are acceptable (depending on the UX direction you plan to go), but at least the following patches seem like a good idea:

Feel free to cherry-pick only these two if the rest is not acceptable.

When the homescreen changes from landscape to
portrait mode (and vice versa), animate the angle.
Make grid tiles smaller horizontally to fit 4 icons
(instead of 3) onto the screen (assuming N950 screen).
We want to use the WallClock in more places than just
the lock screen, so move it into MainScreen.
Use global "wallClock" object in MainScreen instead of
static JS Date object.

Fix layout and colors to look more like in Harmattan.
This removes the background image (improves scrolling
performance, as the background + semi-transparent black
overlay don't need to be drawn) and tab bar, and adds
the favorites screen as first item in the pager.
@@ -67,6 +76,7 @@ Item {
origin.x: mainScreen.height / 2
origin.y: mainScreen.height / 2
angle: desktop.isPortrait ? -90 : 0
Behavior on angle { NumberAnimation { duration: 300; easing.type: Easing.OutCubic } }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the way I'd like this to be done is to use qt-components window, instead of an Item

this also removes the need for the rotation hack (since qt-components already has an understanding of orientation), sensor handling, etc - plus we can ditch some unneeded code out of lipstick (orientation handling, and status bar which is broken anyway)

think you can look into that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd vote against the qt-components dependency, since qt-components is
obsolete anyway.

On Thu, Feb 21, 2013 at 2:28 PM, Robin Burchell notifications@github.comwrote:

In src/qml/MainScreen.qml:

@@ -67,6 +76,7 @@ Item {
origin.x: mainScreen.height / 2
origin.y: mainScreen.height / 2
angle: desktop.isPortrait ? -90 : 0

  •        Behavior on angle { NumberAnimation { duration: 300; easing.type: Easing.OutCubic } }
    

the way I'd like this to be done is to use qt-components window, instead
of an Item

this also removes the need for the rotation hack (since qt-components
already has an understanding of orientation), sensor handling, etc - plus
we can ditch some unneeded code out of lipstick (orientation handling, and
status bar which is broken anyway)

think you can look into that?


Reply to this email directly or view it on GitHubhttps://github.com//pull/9/files#r3098357.

Same as in Harmattan:

 - Longpress to show close buttons
 - "Done" and "Close all" buttons
 - Abort close mode when scrolling out of view
 - Abort close mode when closing last window
@thp
Copy link
Contributor Author

thp commented Feb 21, 2013

Added new commits:

@thp
Copy link
Contributor Author

thp commented Feb 21, 2013

Video for commit 53f0d3c: http://youtu.be/UULh9oLk7oY

Again, very much inspired by Harmattan's UX.
With new qt-components with w00t's patch applied, the
status bar rotation information is correctly applied.
@@ -66,10 +76,72 @@ Item {
}
}

Rectangle {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd prefer a proper toolbar for this, to match theming changes (if we make any), but that can wait I suppose

@rburchell
Copy link
Contributor

I'm going to merge this. Nobody else has been working on the homescreen for a while, so it makes sense to me.

rburchell added a commit that referenced this pull request Feb 21, 2013
Various changes to make the homescreen look nicer
@rburchell rburchell merged commit 6293a83 into nemomobile:master Feb 21, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants