[glacierui] change icon, as it shares with settings icon #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so no way for us to symlink
|
Once this PR is accepted, Glacier icon set will LGTM :)) |
|
git supports symlinks OK, or you could do it at install time I guess. I'd prefer to not do this, as then we'd break existing themes. |
|
Hi, symlinking won't work here for us, as we already symlinked the settings icon for settings app. So we are either stuck with settings icon for screenshot tool or with no icon at all. |
|
Then we need to propose a screenshot icon for existing themes (darko and base) |
|
Good idea, will come up with patches soon. |
|
To make everyone happy, you could add one to Jolla theme as well ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so no way for us to symlink to an own icon in new nemo-theme-glacier