[battery] Notify about charging completion only once. Fixes MER#1171 #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -153,6 +158,12 @@ void BatteryNotifier::prepareNotification() | |||
| checkChargingTimer->start(); | |||
| } | |||
| } | |||
| if (isStateChanged) { | |||
| if (!isAnyChargingState) | |||
There was a problem hiding this comment.
In at least one case above, have used braces around one-line expression, so for consistency it may be best to use enclosing braces here too
There was a problem hiding this comment.
@chriadam I am using kernel conventions (no braces for 1-liners) to avoid extra syntax noise. But not a big deal to change it here, maybe it will be more consistent with the rest of the lipstick code.
There was a problem hiding this comment.
Not a big deal either way, whichever you prefer :-) Just thought I'd mention it.
Do not notify on charging completion during maintenance charging cycles Signed-off-by: Denis Zalevskiy <denis.zalevskiy@jolla.com>
deztructor
force-pushed
the
mer1171-notify-charged-once
branch
from
566d21e
to
fa7ad09
Compare
|
LGTM although I'm not familiar with this code. It would be nice if someone who is could also take a look. |
deztructor
pushed a commit
that referenced
this pull request
Jul 17, 2015
[battery] Notify about charging completion only once. Fixes MER#1171
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not notify on charging completion during maintenance charging cycles
Signed-off-by: Denis Zalevskiy denis.zalevskiy@jolla.com